Skip to content

Partial Implementation of Dark Mode - #218

Open
JOSHMT0744 wants to merge 26 commits into
zineland:masterfrom
JOSHMT0744:dev
Open

Partial Implementation of Dark Mode#218
JOSHMT0744 wants to merge 26 commits into
zineland:masterfrom
JOSHMT0744:dev

Conversation

@JOSHMT0744

Copy link
Copy Markdown

BusyMaestro and I have added css classes for a dark mode. There are references to them in the Jinja files, though more must be made. Theme.rs has an implementation of dark versions of the :root colours. This is toggled via 'zine.toml' under the dark_mode Boolean in [theme]. Any questions, feel free to ask 👍

@Folyd

Folyd commented Apr 28, 2023

Copy link
Copy Markdown
Member

I much appreciate you for working on this. You know, zine is built on Tailwind CSS, a marvelous CSS library to help us build fantastic UI quickly. It supports dark mode. For the article page, we use @tailwindcss/typography plugin, which also supports dark mode. I think we can base it on Tailwind's dark mode. What do you think?

@JOSHMT0744

Copy link
Copy Markdown
Author

We saw that in the latter half of working on this and in fact thought the same. Though, we felt we wanted to complete this implementation as it utilised some ideas which we wanted to use in order to learn more about Rust. Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants