Skip to content

feat: add native PostgreSQL backup and restore - #137

Open
Bhavik-ag wants to merge 1 commit into
mainfrom
feat/backup-restore
Open

Bhavik-ag wants to merge 1 commit into
mainfrom
feat/backup-restore

Conversation

@Bhavik-ag

Copy link
Copy Markdown
Contributor

Summary

  • run pg_dump, pg_restore, and psql directly with shell disabled
  • add native file selection, safe command preview, object filters, custom args, logs, and cancellation
  • pass passwords only through PGPASSWORD and sanitize process output

Notes

  • progress is streamed/indeterminate because PostgreSQL tools do not expose percentage progress
  • directory archive format is not included; custom, plain SQL, and tar are supported

Validation

  • desktop build
  • monorepo typecheck
  • desktop lint
  • 61 desktop tests

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
dbdesk-web Ignored Ignored Sep 19, 2026 3:00am UTC
dbdesk-server Skipped Skipped Sep 19, 2026 3:00am UTC

@vercel
vercel Bot temporarily deployed to Preview – dbdesk-server September 18, 2026 17:24 Inactive
@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The pull request appears safe to merge, with no outstanding blocking or non-blocking findings.

Summary

Adds native PostgreSQL backup and restore support to the Electron desktop application.

  • Runs pg_dump, pg_restore, and psql without a shell and supplies credentials through PGPASSWORD.
  • Adds typed and runtime-validated IPC operations for file selection, previews, execution, cancellation, and progress events.
  • Adds a workspace dialog for archive options, object filtering, logs, cancellation, and post-restore metadata refresh.
  • Uses temporary output files to avoid replacing an existing backup until a new backup completes successfully.
  • The changes since the previous review correctly permit single-worker restores while continuing to reject worker counts incompatible with transactional restore.

Reviews (4) · Last reviewed commit: "feat(desktop): add PostgreSQL backup and..."

Comment thread apps/desktop/src/main/lib/database-tools.ts Outdated
Comment thread apps/desktop/src/main/ipc/typed-handle.ts
@vercel
vercel Bot temporarily deployed to Preview – dbdesk-server September 18, 2026 17:36 Inactive
@vercel
vercel Bot temporarily deployed to Preview – dbdesk-server September 18, 2026 17:40 Inactive
Comment thread apps/desktop/src/main/lib/database-tools.ts
@vercel
vercel Bot temporarily deployed to Preview – dbdesk-server September 19, 2026 02:52 Inactive
Comment thread apps/desktop/src/main/lib/database-tools.ts Outdated
Comment thread apps/desktop/src/main/ipc/database-tool-handlers.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant