Fix recreating NLA profile after reconnect on Windows - #2602
Open
Accurio wants to merge 1 commit into
Open
Conversation
The fake ARP entry used to trick Windows NLA into recognizing this adapter as a real network derived its gateway MAC from the tap adapter's NetCfgInstanceId GUID. Since Disconnect then Reconnect in ZeroTier fully uninstalls and recreates the tap adapter, each reconnect produced a new random GUID and therefore a new fake gateway MAC. NLA treats this as a distinct network and ignores the previously configured network profile each time. This change derives the fake gateway MAC from the ZeroTier network ID instead of the device GUID, so the NLA signature stays stable across tap adapter recreation as long as the network ID is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fake ARP entry used to trick Windows NLA into recognizing this adapter as a real network derived its gateway MAC from the tap adapter's NetCfgInstanceId GUID. Since Disconnect then Reconnect in ZeroTier fully uninstalls and recreates the tap adapter, each reconnect produced a new random GUID and therefore a new fake gateway MAC. NLA treats this as a distinct network and ignores the previously configured network profile each time.
This change derives the fake gateway MAC from the ZeroTier network ID instead of the device GUID, so the NLA signature stays stable across tap adapter recreation as long as the network ID is unchanged.