Conversation
- hydrate the main process env from the login shell before publishing auth/model status - keep this best-effort so auth still initializes if shell env loading fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hydrate the main-process environment from the user's login shell on macOS before publishing auth/model status.
When Zenbu is launched from Finder/Dock, macOS provides a reduced environment. In that state the model list appears, but selecting a model does not persist and sending messages fails silently. Launching the same app from Terminal works because it inherits the shell environment.
This uses the existing
shell-envdependency and runs once duringAuthService.evaluate()before the Pi auth storage/model registry publishes provider status.Repro
Expected: the model selection persists and the message starts an agent turn.
Actual: the model list appears, but selecting a model does not stick, and sending a message clears/fails without an agent response.
Then launch the same app from Terminal:
The model picker and message sending work.
Testing
Typechecked the patched installed copy:
Verified with a Finder-launched wrapper app pointed at an isolated patched source copy: