fix: restrict hover trigger to 4px strip and fix bookmark overflow#2084
Open
shrigiri81 wants to merge 2 commits into
Open
fix: restrict hover trigger to 4px strip and fix bookmark overflow#2084shrigiri81 wants to merge 2 commits into
shrigiri81 wants to merge 2 commits into
Conversation
shrigiri81
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2041
Fixes two issues with the bookmarks toolbar:
The hover area covered the entire 70px navbar, making it trigger too easily. It's now limited to a 4px strip by giving the toolbar an explicit height and using
margin-bottom: -4pxso it doesn't affect page layout. When expanded, the toolbar switches toposition: absoluteso it overlays the page instead of causing a reflow.The bookmarks toolbar wasn't showing the
>chevron when there were too many bookmarks because the items could overflow. Fixed by setting the toolbar towidth: 100%and addingoverflow: hiddento#PlacesToolbarItems.