Repository navigation
Fix duplicate labels in live formula previews - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a formula containing
\label{eq:demo}could show “Label 'eq:demo' multiply defined” because the paper and live preview registered the same equation in shared MathJax state. Draft previews and edited-formula rendering now use a fresh TeX input instance and separate MathDocument, copy existing document references, and suppress label registration only in that draft instance. Editor text and saved feedback retain the complete source, including labels.Async preview results only update the current draft. Saving multiple formula edits also uses each formula's own original source for its feedback anchor, rather than the last-opened editor's baseline.
Validation:
The isolated conversion uses MathJax 3's exposed startup constructors and conversion machinery; the browser regression should be rerun when upgrading MathJax. Browser suites use a separately installed Playwright and are documented in docs/renderer-adapters.md; the existing GitHub CI covers the Python matrix.
Fixes #19