Preserve static neighbors during interface reload - #335
Open
ezhk wants to merge 2 commits into
Open
Conversation
ezhk
marked this pull request as ready for review
August 4, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
neighbor_update_interfacesswitched and garbage-collected the previous interface map beforeDumpOSNeighborsrebuilt the neighbor table. Static entries could no longer be translated to the new interface IDs, so the rebuild could publish a table without them during an asynchronous reload and packets were dropped.The deferred generation update also captured the dump and static-entry vectors by reference. The callback now owns those vectors so they remain valid until it runs.
Impact
Reloads retain existing static neighbors while new interface IDs are applied, avoiding transient packet loss such as the first-packet miss in
049_balancer_reload.Validation
yanet-dataplane-unittest-neighbor: 3 tests passedautotest/units/001_one_port/049_balancer_reload: passed all packet stagesgit diff --check: clean