You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a source-prefix parsing issue to fix before merge.
source_ipv6_prefixes validates the mask with std::stoul(mask_string) (decimal), but then constructs ipv6_prefix_t from the original string. That constructor parses the mask with base 0, so leading-zero masks are interpreted as octal: for example, 2001:db8::/064 passes validation but becomes /52, while ::/08 becomes /0. This can make the generated ACL select the NAT64 module for a much broader source range than configured.
Please construct the prefix using the already-parsed decimal mask (or reject noncanonical leading-zero masks).
The added autotest currently checks only the default ::/0 CLI output. It would also be valuable to configure a non-default source prefix and verify packets from both matching and non-matching source ranges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
source_ipv6_prefixesfield support to nat64stateful modules.The control plane now:
::/0as the default source prefix.nat64statefulCLI output.