feat(query-coordinator): Add query job coordination loop. - #2525
Draft
Bill-hbrhbr wants to merge 95 commits into
Draft
feat(query-coordinator): Add query job coordination loop.#2525Bill-hbrhbr wants to merge 95 commits into
Bill-hbrhbr wants to merge 95 commits into
Conversation
Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com>
Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com>
Co-authored-by: Lin Zhihao <59785146+LinZhihao-723@users.noreply.github.com>
… search results to the results cache. Implements `query::clp_s_query_to_results_cache`, mirroring the Celery task in `job_orchestration.executor.query.fs_search_task`. The task resolves one archive from either filesystem- or S3-backed archive output, invokes `clp-s s`, and lets `clp-s` write the matches to MongoDB itself. Aggregation and the file/network/reducer output handlers are not supported. * Add `OutputHandle` to `task_io::query` and make `ClpSQueryOption::max_num_results` optional, so `None` means no task-level limit rather than silently inheriting the `clp-s` default of 1000. Correct the `begin_timestamp`/`end_timestamp` doc comments, which said microseconds; the whole chain is milliseconds. * Add `ArchiveOutput::dataset_archive_object_key`, and move `clp_binary_path` and `s3_credential_env` out of the compression task into `task::clp_s`, so the compression and query paths share one definition of the archive layout and of the AWS credential environment. * Resolve a `None` dataset to `default` on the Rust side and always pass `--dataset`, so every result document carries a truthful dataset name instead of an empty string.
…env` into a shared `task::utils` module.
* Pass the query job ID into `build_clp_s_search_args_for_result_cache` and derive the results-cache collection name inside it. * Rename `build_clp_s_search_args` to `build_clp_s_search_args_for_result_cache`. * Log an error when archive-input resolution fails. * Tighten the task's docstrings and error messages.
…`clp-s` search task: * Rename the `build_clp_s_search_args_for_result_cache` unit tests to match the function's name. * Rename `results_cache_uri` to `result_cache_uri`.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bill-hbrhbr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the query coordinator loop, following the compression coordinator’s structure and using #2513’s
QueryJobHandleinterface.SearchJobConfigandOutputHandleto the handler.dispatch_timecolumn.Depends on #2513 and uses #2512’s output-handle definitions.