ci!: Remove CentOS Stream 9 platform support - #2511
Open
jackluo923 wants to merge 3 commits into
Open
Conversation
…4) image. Adds an arm64 leg that consumes the existing aarch64 dependency image, publishes each arch under an arch-suffixed tag, and merges them into a multi-arch manifest, mirroring `package-image`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CentOS Stream 9 is no longer a supported platform: - Delete the centos-stream-9 deps-image and binaries jobs, its paths-filter output, and deps-cache-key fragment from clp-artifact-build.yaml; relocate the deps-cache YAML anchors into the manylinux_2_28-x86_64-binaries job. - Delete tools/docker-images/clp-env-base-centos-stream-9/ and tools/scripts/lib_install/centos-stream-9/. - Remove the /etc/centos-release static-linking guard from components/core/CMakeLists.txt (AlmaLinux/manylinux_2_28 behavior unchanged). - Remove the CentOS CA-bundle fallback from CurlDownloadHandler; CA discovery still honors CURL_CA_BUNDLE/SSL_CERT_FILE and the Debian default path, and distro libcurl defaults cover RHEL-family hosts. - Remove the centos-stream-9 docs page, its toctree/link entries, the dependencies-image docs section, and related workflow docs.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (11)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe workflow removes CentOS Stream 9 builds and support files. It retains manylinux cache configuration and changes Spider Worker image builds to amd64 and arm64, followed by multi-architecture manifest publishing. CentOS-specific static-linking and CA bundle handling are removed. ChangesPlatform build updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change removes CentOS Stream 9 support and updates the related CI, build scripts, runtime fallbacks, and documentation; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant DependencyImages
participant SpiderWorkerImage
participant GHCR
GitHubActions->>DependencyImages: Select amd64 or arm64 dependency image
DependencyImages->>SpiderWorkerImage: Provide architecture-specific build environment
SpiderWorkerImage->>GHCR: Push architecture-suffixed image
GitHubActions->>GHCR: Publish the combined main manifest
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jackluo923
marked this pull request as ready for review
September 1, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We no longer want to support CentOS Stream 9 platform, so this PR removes all traces of it from the repo:
clp-artifact-build.yaml): delete thecentos-stream-9-deps-imageandcentos-stream-9-binariesjobs, thecentos_stream_9_image_changedoutput and its paths-filter block, and thecentos-stream-9deps-cache-key fragment. The&deps_cache_paths/&deps_cache_save_conditionYAML anchors that previously lived in the deleted job are relocated intomanylinux_2_28-x86_64-binariesso the musllinux and ubuntu jobs continue to resolve them.components/core/tools/docker-images/clp-env-base-centos-stream-9/andcomponents/core/tools/scripts/lib_install/centos-stream-9/.elseif (EXISTS "/etc/centos-release")static-linking guard fromcomponents/core/CMakeLists.txt. The removed block explicitly exempted AlmaLinux, so manylinux_2_28 behavior is unchanged./etc/pki/tls/certs/ca-bundle.crt) fromCurlDownloadHandler::get_host_ca_bundle_path(). Discovery still honorsCURL_CA_BUNDLE/SSL_CERT_FILEand the Debian default path; when no path is found,CURLOPT_CAINFOis simply not set and libcurl falls back to its compiled-in default, which on RHEL-family distros is that same path.centos-stream-9-deps-install.mdpage, remove its bullet link and hidden-toctree entry fromcomponents-core/index.md, remove theclp-core-dependencies-x86-centos-stream-9section (plus the staleDNF_MIRROR_BASE_URLdistro entry and unused link reference) fromtooling-containers.md, and remove the corresponding mermaid edges and job bullets fromtooling-gh-workflows.md.The published
ghcr.io/y-scope/clp/clp-core-dependencies-x86-centos-stream-9:mainimage still exists in the registry; registry cleanup is out of scope for this PR.Checklist
breaking change.
Validation performed
grepforcentos/stream-9/stream9/clp-env-base-centos-stream-9: the only remaining match is the* CentOS/RHEL 8+compatibility note for the (retained) manylinux_2_28/AlmaLinux image intooling-containers.md.clp-artifact-build.yamlparses with PyYAML; no dangling jobneeds:, outputs, or YAML anchor references; all 10*deps_cache_paths/*deps_cache_save_conditionuses occur after the relocated definitions.bash -npasses on the two editedcorporate-proxy-*.shscripts.tools/scripts/find-broken-docs-links.pyexits 0 (no broken docs links); the toctree targets incomponents-core/index.mdall exist on disk.Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores