Skip to content

fix(taskfile): Generate the tests:rust-all LocalStack container name via uv so that a missing uuidgen no longer yields an empty name (fixes #2465). - #2469

Draft
jackluo923 wants to merge 3 commits into
y-scope:mainfrom
jackluo923:fix/localstack-container-name

Conversation

@jackluo923

@jackluo923 jackluo923 commented Aug 10, 2026

Copy link
Copy Markdown
Member

Description

Resolves LOCALSTACK_CONTAINER_NAME with a single uv run python command instead of a uuidgen | tr | sed pipeline, so that a missing interpreter fails the task rather than yielding an empty name. uv is already a prerequisite and already resolves the adjacent LOCALSTACK_PORT, so this adds no dependency.

Fixes #2465.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

On Ubuntu 26.04 (WSL2, aarch64) without uuidgen installed:

  • uv run python -c "import uuid; print('clp-localstack-rust-' + str(uuid.uuid4()))" prints clp-localstack-rust-a34aac8f-d8ad-4efd-a9e7-c0be446d5053 and exits 0.
  • task --dry tests:rust-all shows the name reaching start.py and the deferred stop.py: --name "clp-localstack-rust-69b62977-0ae5-490c-b7a5-81ee93354d32".
  • task lint:check-yaml passes.

The full tests:rust-all suite was not run locally; the CI job covers it.

…e via `uv` so that a missing `uuidgen` no longer yields an empty name (fixes y-scope#2465).
@jackluo923
jackluo923 requested a review from a team as a code owner August 10, 2026 17:02
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c3bddd9e-b6fc-442f-b96a-4d7dd991d5ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

The LocalStack test task now generates its container name with uv run python and uuid.uuid4(). This removes the uuidgen dependency and shell-based casing normalization.

Changes

LocalStack test task

Layer / File(s) Summary
UUID-based container naming
taskfiles/tests/main.yaml
The task uses uv run python to generate a lowercase UUID and preserve the clp-localstack-rust- prefix.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: davidlion, junhaoliao, kirkrodrigues, linzhihao-723

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the taskfile fix, the uv-based container name generation, and the missing uuidgen failure condition.
Linked Issues check ✅ Passed The change replaces the failing uuidgen pipeline with uv run python and uuid.uuid4(), addressing issue #2465 without adding a dependency.
Out of Scope Changes check ✅ Passed The one-line taskfile change is limited to the linked issue and stated objectives; no unrelated code changes are shown.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jackluo923
jackluo923 marked this pull request as draft August 10, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The tests:rust-all task leaks a running LocalStack container when uuidgen is unavailable.

1 participant