feat(packaging): Add a busybox init-container installer image as a fourth distribution channel. #36
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # Builds the busybox init-container installer image from a connector package tarball. | ||
| # | ||
| # The image bundles both plugins (coordinator JAR + native worker .so and lib/) and, when | ||
| # run, installs each into a mounted target directory. See tools/build-packages/README.md. | ||
| # | ||
| # Reusable by local builds (build-packages.sh, --load) and CI (--push). Prints the built | ||
| # image reference to stdout. | ||
| # | ||
| # Requires: docker (with buildx), git, tar. | ||
|
|
||
| set -o errexit | ||
| set -o nounset | ||
| set -o pipefail | ||
|
jackluo923 marked this conversation as resolved.
|
||
|
|
||
| script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)" | ||
| image_dir="${script_dir}/image" | ||
|
|
||
| # Shared helpers: image_repo_from_origin (GHCR repo derivation) and _REPO_ROOT. | ||
| source "${script_dir}/dependency-image/utils.sh" | ||
|
|
||
| show_help() { | ||
| cat <<'EOF' | ||
| Usage: ./tools/build-packages/build-installer-init-image.sh --tarball FILE [OPTIONS] | ||
|
|
||
| Builds the busybox init-container installer image from a connector package tarball | ||
| (clp-plugin-presto-connector-<version>-linux-<arch>.tar.gz). | ||
|
|
||
| Options: | ||
| --tarball FILE Package tarball to build the image from (required) | ||
| --version VER Image version tag (default: parsed from the tarball name) | ||
| --arch ARCH amd64 or arm64 (default: parsed from the tarball name) | ||
| --repo REPO Image repository (default: derived from the git origin remote, | ||
| e.g. ghcr.io/y-scope/clp-plugin-presto-connector) | ||
| --push Push the image to the registry (default: --load into local docker) | ||
| --load Load the image into the local docker daemon (default) | ||
| --help Show this help | ||
|
|
||
| See tools/build-packages/README.md for details. | ||
| EOF | ||
| } | ||
|
|
||
| die() { | ||
|
jackluo923 marked this conversation as resolved.
Outdated
|
||
| echo >&2 "ERROR: $*" | ||
| exit 1 | ||
| } | ||
|
|
||
| require_value() { | ||
| [[ -n "${2:-}" ]] || die "$1 requires a value" | ||
| } | ||
|
|
||
| # ── Parse arguments ─────────────────────────────────────────────────────────── | ||
|
|
||
| tarball="" | ||
| version="" | ||
| arch="" | ||
| repo="" | ||
| output="--load" | ||
|
|
||
| while [[ $# -gt 0 ]]; do | ||
| case $1 in | ||
| --tarball) require_value "$1" "${2:-}"; tarball="$2"; shift 2 ;; | ||
| --version) require_value "$1" "${2:-}"; version="$2"; shift 2 ;; | ||
| --arch) require_value "$1" "${2:-}"; arch="$2"; shift 2 ;; | ||
| --repo) require_value "$1" "${2:-}"; repo="$2"; shift 2 ;; | ||
| --push) output="--push"; shift ;; | ||
| --load) output="--load"; shift ;; | ||
| --help) show_help; exit 0 ;; | ||
| *) die "unknown option: $1 (use --help for usage)" ;; | ||
| esac | ||
| done | ||
|
|
||
| [[ -n "${tarball}" ]] || die "--tarball is required (use --help for usage)" | ||
| [[ -f "${tarball}" ]] || die "tarball not found: ${tarball}" | ||
|
|
||
| command -v docker &>/dev/null || die "docker is required" | ||
| docker buildx version &>/dev/null || die "docker buildx is required" | ||
|
|
||
| # ── Resolve version and arch from the tarball name when not given ────────────── | ||
|
|
||
| # Tarball name format: clp-plugin-presto-connector-<version>-linux-<arch>.tar.gz | ||
| tar_base="$(basename "${tarball}")" | ||
| tar_base="${tar_base%.tar.gz}" | ||
| name_rest="${tar_base#clp-plugin-presto-connector-}" | ||
| if [[ "${name_rest}" == "${tar_base}" || "${name_rest}" != *-linux-* ]]; then | ||
| die "cannot parse tarball name '${tar_base}'; pass --version and --arch explicitly" | ||
| fi | ||
| [[ -n "${arch}" ]] || arch="${name_rest##*-linux-}" | ||
| [[ -n "${version}" ]] || version="${name_rest%-linux-"${arch}"}" | ||
|
|
||
| case "${arch}" in | ||
| amd64) platform="linux/amd64" ;; | ||
| arm64) platform="linux/arm64" ;; | ||
| *) die "unsupported arch: ${arch} (expected amd64 or arm64)" ;; | ||
| esac | ||
|
|
||
| [[ -n "${repo}" ]] || repo="$(image_repo_from_origin)" | ||
|
|
||
| # Docker tags allow only [A-Za-z0-9_.-]; sanitize any other version characters (e.g. '+'). | ||
| tag_version="${version//[^A-Za-z0-9_.-]/_}" | ||
|
Member
There was a problem hiding this comment. this replacement is lossy: valid versions package_version_to_image_tag() {
local version="$1"
[[ "${version}" =~ ^[0-9][0-9A-Za-z.+~-]*$ ]] || return 1
local tag_version="${version//+/_plus_}"
tag_version="${tag_version//\~/_tilde_}"
printf '%s\n' "${tag_version}"
}
tag_version="$(package_version_to_image_tag "${version}")" ||
die "invalid package version: ${version}"
Member
Author
There was a problem hiding this comment. Connector version shouldn't contain "+" or "~". Mistake on my part. I will switch to fail loudly if these versions are encountered. |
||
| image="${repo}:${tag_version}-${arch}" | ||
|
|
||
| # ── Assemble a self-contained build context and build ───────────────────────── | ||
|
|
||
| context_dir="$(mktemp -d)" | ||
| trap 'rm -rf "${context_dir}"' EXIT | ||
|
|
||
| # Extract the install tree so coordinator/ and worker/ sit at the context root, matching the | ||
| # Dockerfile's COPY paths. --strip-components=1 drops the versioned top-level directory. | ||
| tar -xzf "${tarball}" -C "${context_dir}" --strip-components=1 | ||
| [[ -d "${context_dir}/coordinator" && -d "${context_dir}/worker" ]] \ | ||
| || die "tarball did not contain coordinator/ and worker/ trees" | ||
|
|
||
| cp "${image_dir}/Dockerfile" "${image_dir}/entrypoint.sh" "${context_dir}/" | ||
|
|
||
| echo >&2 "==> Building installer image ${image} (${platform})..." | ||
| docker buildx build \ | ||
| --platform "${platform}" \ | ||
| --tag "${image}" \ | ||
| "${output}" \ | ||
| -f "${context_dir}/Dockerfile" \ | ||
| "${context_dir}" | ||
|
|
||
| echo >&2 "==> Built ${image}" | ||
| echo "${image}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # syntax=docker/dockerfile:1 | ||
|
|
||
| # Init-container installer image for the CLP Presto connector. | ||
| # | ||
| # Bundles both plugins and, when run, copies each into a mounted target directory. The | ||
| # build context is an extracted package install tree (coordinator/ + worker/), assembled by | ||
| # build-installer-init-image.sh. See tools/build-packages/README.md. | ||
|
|
||
| # The installer only runs busybox's own sh/cp/mkdir to copy files; it never executes the | ||
| # plugin, so the libc flavor is irrelevant. Pin the small musl variant for a tiny image. | ||
| FROM busybox:1.37.0-musl | ||
|
jackluo923 marked this conversation as resolved.
|
||
|
|
||
| # Match the .deb/.rpm install root (PLUGIN_ROOT) so all channels share one layout. | ||
| COPY coordinator /opt/clp-plugin-presto-connector/coordinator | ||
| COPY worker /opt/clp-plugin-presto-connector/worker | ||
| COPY --chmod=0755 entrypoint.sh /usr/local/bin/install-clp-plugin | ||
|
|
||
| ENTRYPOINT ["/usr/local/bin/install-clp-plugin"] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.