feat: support Windows MSVC builds - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
f85a853692a8c730d0270cd733c8bb30b5b93b7c-C target-cpu=nativenow selects host-native compiler tuning while portable builds retain runtime dispatchvendor_vmaf.pyIndividual upstream patches
ya_getopt.patch- Add ya_getopt, a 2-clause-BSD-licensed implementation of getopt_long() Netflix/vmaf#1410msvc_no_vla.patch- MSVC: Avoid the use of variable-length arrays Netflix/vmaf#1428avx2_simd_portability.patch- AVX2: Improve SIMD portability by replacing non‑portable indexing and casts Netflix/vmaf#1475vif_void_pointer.patch- Fix UB in void* pointer arithmetic and memory leak in VIF init Netflix/vmaf#1476Local patches keep the private pthread layer, MSVC SIMD build wiring, FMA-safe AVX2 dispatch, and checked VIF copy-size arithmetic separate.
Validation
python3 check_vmaf_version.pypython3 -m py_compile vendor_vmaf.py check_vmaf_version.pyactionlint .github/workflows/*.ymlcargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --no-default-featurescargo test --all-features(two native VMAF worker threads)DOCS_RS=1 RUSTDOCFLAGS="-D warnings" cargo doc --all-features --no-depscargo package --allow-dirtyCFLAGS=-Werror=vla cargo check --no-default-featuresRUSTFLAGS="-C target-cpu=native" cargo check --all-features; verified the C command contains Meson release-O3and-mcpu=nativecargo ndk --platform 24 --target armeabi-v7a --link-builtins --link-libcxx-shared test --lib --no-run(scalar ARMv7 feature kernels)