Skip to content

feat: support Windows MSVC builds - #1

Merged
xnorpx merged 15 commits into
mainfrom
ci/windows-msvc
Aug 28, 2026
Merged

xnorpx merged 15 commits into
mainfrom
ci/windows-msvc

Conversation

@xnorpx

@xnorpx xnorpx commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • update vendored Netflix/VMAF master to f85a853692a8c730d0270cd733c8bb30b5b93b7c
  • add native Windows MSVC support with private Windows threading and runtime-dispatched AVX2/AVX-512 kernels
  • propagate host Rust CPU settings into libvmaf C/C++ compilation; -C target-cpu=native now selects host-native compiler tuning while portable builds retain runtime dispatch
  • recreate Meson output on build-script reruns so CPU flags cannot become stale
  • run real two-thread JPEG scoring on every supported host
  • apply local patches automatically from vendor_vmaf.py

Individual upstream patches

Local patches keep the private pthread layer, MSVC SIMD build wiring, FMA-safe AVX2 dispatch, and checked VIF copy-size arithmetic separate.

Validation

  • regenerated current VMAF through the complete ordered patch series
  • python3 check_vmaf_version.py
  • python3 -m py_compile vendor_vmaf.py check_vmaf_version.py
  • actionlint .github/workflows/*.yml
  • cargo fmt --all -- --check
  • five direct build-script configuration tests
  • cargo clippy --all-targets --all-features -- -D warnings
  • cargo test --no-default-features
  • cargo test --all-features (two native VMAF worker threads)
  • DOCS_RS=1 RUSTDOCFLAGS="-D warnings" cargo doc --all-features --no-deps
  • cargo package --allow-dirty
  • CFLAGS=-Werror=vla cargo check --no-default-features
  • RUSTFLAGS="-C target-cpu=native" cargo check --all-features; verified the C command contains Meson release -O3 and -mcpu=native
  • cargo ndk --platform 24 --target armeabi-v7a --link-builtins --link-libcxx-shared test --lib --no-run (scalar ARMv7 feature kernels)

@xnorpx xnorpx changed the title ci: test Windows MSVC builds feat: support Windows MSVC builds Aug 28, 2026
Comment thread vendored/vmaf/libvmaf/src/feature/vif_tools.c Fixed
@xnorpx
xnorpx merged commit 55536bd into main Aug 28, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants