Conversation
paireks
force-pushed
the
XEOK-511-add-scale-axis-for-ortho
branch
from
September 30, 2026 10:05
bff887a to
c4ede29
Compare
xeolabs
approved these changes
Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @MichalDybizbanskiCreoox and @xeolabs,
this PR is about making it possible to support BCF 3.0 files in the future. BCF 3.0 requires using ortho scale as vertical (https://github.com/buildingSMART/BCF-XML/blob/release_3_0/Documentation/README.md?plain=1#L378), while our Ortho camera sets automatically scale to vertical or horizontal, depending on the aspect. In this PR scaleAxis is added so it's possible to set the actual axis for which scale would be applied.
It's this topic #2071 but revisited. I changed the namings into scaleAxis as it makes it more clear what it does to me, and it is more consistent with the existing Perspective's fovAxis namings.
Please let me know what you think, I will update d.ts types when this part will be accepted.
Wojciech