Skip to content

Support conventional command forwarding - #8

Open
martinohansen wants to merge 2 commits into
mainfrom
martin/scratch-forwarding
Open

Support conventional command forwarding#8
martinohansen wants to merge 2 commits into
mainfrom
martin/scratch-forwarding

Conversation

@martinohansen

Copy link
Copy Markdown
Contributor

Enable the standard -- argument boundary so scratch can pass child
options to tools such as psql without parsing them as Xata flags.

Enable the standard -- argument boundary so scratch can pass child
options to tools such as psql without parsing them as Xata flags.

@divyenduz divyenduz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added some minor comments.

Comment thread src/commands/scratch.ts Outdated
Comment thread src/app.ts
export const app = buildApplication(addGlobalFlags(routes), {
name: CLI_NAME,
scanner: {
allowArgumentEscapeSequence: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects all commands btw, not just scratch, so might be a good moment to think if this might negatively affect any other command.

Co-authored-by: div <divyendu@xata.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants