fix: use asyncio.to_thread for non-blocking input in async chat examples - #216
Open
bodapatisaikrishna wants to merge 1 commit into
Open
bodapatisaikrishna wants to merge 1 commit into
bodapatisaikrishna wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
In
README.md(under Multi-Turn Chat (Asynchronous)) andexamples/aio/chat.py, synchronous standardinput("You: ")was invoked directly inside coroutines running on the asyncio event loop.Calling synchronous blocking I/O on the main thread event loop blocks all concurrent background tasks, timeouts, polling timers, and streaming handlers until the user presses Enter.
This change:
README.mdto useprompt = await asyncio.to_thread(input, "You: ").ainput(prompt)wrappingasyncio.to_thread(input, prompt)inexamples/aio/chat.pyand updates all chat loops (basic_chat,chat_with_streaming,batch_chat,batch_chat_with_streaming).Related Issue
Resolves #213
Type of Change
Additional Notes
Validated locally:
uv run ruff format --check: All 124 files formatted.uv run ruff check: All checks passed.uv run pyright: 0 errors, 0 warnings.uv run pytest -q: 831 passed.