Skip to content

[Wave 10] Generate public SDK size claims from measured artifacts - #205

Merged
truthixify merged 10 commits into
wraith-protocol:developfrom
Nacho1499:public-SDK
Oct 20, 2026
Merged

truthixify merged 10 commits into
wraith-protocol:developfrom
Nacho1499:public-SDK

Conversation

@Nacho1499

Copy link
Copy Markdown
Contributor

Closes #194

Summary

  • Define the size claim as the published EVM ESM entrypoint (@wraith-protocol/sdk/chains/evm) compressed with gzip level 9.
  • Generate the measured size from the installed SDK artifact with pnpm generate:sdk-size.
  • Use the generated value in the home and press page copy.
  • Fail the build if the generated claim differs from the measured artifact.

Verification

  • Production build passed.
  • Unit tests passed (359 tests).
  • Confirmed a stale generated value fails the size check.

@Nacho1499
Nacho1499 requested a review from truthixify as a code owner October 19, 2026 08:34
@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Nacho1499 is attempting to deploy a commit to the truthixify's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Nacho1499 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defines twice. JSON parsers keep the later key, so is silently overwritten and the claimed stale-size build gate never executes even though CI is green. Please combine the size check and existing content validation into one script and add a regression check that proves a stale generated value fails the build.

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json defines scripts.build twice. JSON parsers keep the later key, so the SDK-size check is silently overwritten and the claimed stale-size build gate never executes even though CI is green. Please combine the size check and existing content validation into one build script and add a regression check that proves a stale generated value fails the build.

@truthixify
truthixify dismissed their stale review October 19, 2026 14:24

Dismissed because the review body was corrupted while posting; a corrected review follows.

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json still contains two scripts.build keys at lines 8 and 10. JSON keeps the second value, so the SDK-size check is still discarded from the real build. The new regression test detects this correctly and CI fails 1 of 599 tests. Remove the duplicate and keep a single build command that runs both content validation and the SDK-size check; then rerun the full unit gate.

@Nacho1499

Copy link
Copy Markdown
Contributor Author

done boss

@truthixify truthixify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicate build key is removed, so content validation and the SDK-size freshness check now run in the same production build. Local verification passed the production build, both focused regression files (31 tests), and the full formatting gate; required CI checks are green.

@truthixify
truthixify merged commit 6dad9ca into wraith-protocol:develop Oct 20, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wave 10] Generate public SDK size claims from measured artifacts

2 participants