Repository navigation
[Wave 10] Generate public SDK size claims from measured artifacts - #205
Conversation
|
@Nacho1499 is attempting to deploy a commit to the truthixify's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Nacho1499 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
truthixify
left a comment
There was a problem hiding this comment.
defines twice. JSON parsers keep the later key, so is silently overwritten and the claimed stale-size build gate never executes even though CI is green. Please combine the size check and existing content validation into one script and add a regression check that proves a stale generated value fails the build.
truthixify
left a comment
There was a problem hiding this comment.
package.json defines scripts.build twice. JSON parsers keep the later key, so the SDK-size check is silently overwritten and the claimed stale-size build gate never executes even though CI is green. Please combine the size check and existing content validation into one build script and add a regression check that proves a stale generated value fails the build.
Dismissed because the review body was corrupted while posting; a corrected review follows.
truthixify
left a comment
There was a problem hiding this comment.
package.json still contains two scripts.build keys at lines 8 and 10. JSON keeps the second value, so the SDK-size check is still discarded from the real build. The new regression test detects this correctly and CI fails 1 of 599 tests. Remove the duplicate and keep a single build command that runs both content validation and the SDK-size check; then rerun the full unit gate.
|
done boss |
truthixify
left a comment
There was a problem hiding this comment.
The duplicate build key is removed, so content validation and the SDK-size freshness check now run in the same production build. Local verification passed the production build, both focused regression files (31 tests), and the full formatting gate; required CI checks are green.
Closes #194
Summary
@wraith-protocol/sdk/chains/evm) compressed with gzip level 9.pnpm generate:sdk-size.Verification