Skip to content

ci: enforce Lighthouse category budgets - #178

Closed
olalois wants to merge 4 commits into
wraith-protocol:developfrom
olalois:ci/lighthouse-budget-gate
Closed

olalois wants to merge 4 commits into
wraith-protocol:developfrom
olalois:ci/lighthouse-budget-gate

Conversation

@olalois

@olalois olalois commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Run mobile and desktop Lighthouse audits and fail CI when a required category scores below 95.
  • Comment on PRs with failing routes and categories.
  • Document and test the label-plus-reason budget override.

Closes #154

@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

@olalois is attempting to deploy a commit to the truthixify's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@olalois Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@github-actions
github-actions Bot changed the base branch from main to develop September 26, 2026 14:37
@github-actions

Copy link
Copy Markdown
Contributor

Auto-retargeted this PR from main to develop. Wave PRs merge into develop; main is only for release cuts. If you meant to target main deliberately (rare), reply here and we can revert this.

@olalois

olalois commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Auto-retargeted this PR from main to develop. Wave PRs merge into develop; main is only for release cuts. If you meant to target main deliberately (rare), reply here and we can revert this.

did not intend to target main

@olalois

olalois commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Hello, Kindly review please.
Retargeted to develop

@truthixify

Copy link
Copy Markdown
Contributor

The workflow has duplicate pull_request branches keys, unpinned actions, and write permissions on the build job. It also runs build twice. Please fix the YAML, pin every action to a commit SHA, and move PR comments into a least-privilege job.

@truthixify

Copy link
Copy Markdown
Contributor

CI stops because pnpm-lock.yaml has a duplicate key near line 891. The fork run also cannot post the PR comment. Please regenerate the lockfile and move commenting to a separate least-privilege workflow that never executes PR code.

@truthixify

Copy link
Copy Markdown
Contributor

The rebase still leaves a duplicate key in pnpm-lock.yaml near line 891, so all required jobs fail before Lighthouse runs. Regenerate the lockfile from clean develop and rerun CI.

@truthixify

Copy link
Copy Markdown
Contributor

Wave 9 has ended, so this PR is being closed without merging. Thank you for the contribution.

@truthixify truthixify closed this Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Wave 9] Make Lighthouse budget failures block the website build

2 participants