Fix self-hosted Stats connection loading - #25858
Open
crazytonyli wants to merge 2 commits into
Open
Conversation
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33552 | |
| Version | PR #25858 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | af0d41b | |
| Installation URL | 6tkli1bc07l6o |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33552 | |
| Version | PR #25858 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | af0d41b | |
| Installation URL | 4lpgp7aojveh8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To reproduce the issue: Sign in to the Jetpack app with a XML-RPC disabled self-hosted site that is not connected to Jetpack. On My Site, tap Stats and wait. The Stats screen stays on a loading indicator instead of showing the "Connect your site" screen.
Core REST sites were falling through
BlogService.syncBlogwithout invoking either callback. It now refreshes self-hosted site options through XML-RPC, using the application password when needed, while preserving the existing WordPress.com REST path.