-
Notifications
You must be signed in to change notification settings - Fork 3
fix(ios)!: localize the patterns count and let hosts fall back to editor strings #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
137f5ed
fix: Localize patterns count string
dcalhoun d112327
feat(ios): let host apps fall back to the editor's default strings
dcalhoun 1958269
fix(ios): report missing translations where hosts can see them
dcalhoun b18641c
fix(ios): let host apps call defaultLocalize from a nonisolated context
dcalhoun 14ecd81
fix(ios): report each missing translation once, with an opt-out
dcalhoun ea81e3d
refactor(ios): drop CaseIterable from EditorLocalizableString
dcalhoun 9008006
fix(ios): stop reporting strings the host does translate
dcalhoun 40f35ec
docs(ios): recommend @unknown default for host localization
dcalhoun 42b4bb4
refactor(ios)!: let hosts decline a key by returning nil
dcalhoun 191ae2b
docs(ios): trim localization docs to the current design
dcalhoun c33a1e6
docs(ios): restore @unknown default in the localize example
dcalhoun b08789c
refactor(ios): isolate localize and the subscript, not the whole class
dcalhoun b681e10
refactor(ios): scope the reporting lock to the key set
dcalhoun 7b48e6d
docs(ios): state the reporting flag's contract for hosts
dcalhoun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
EditorLocalization.localizeallow returning a nil, which means GBK can calldefaultLocalizeinternally, rather than requiring the app to call it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach makes sense. Thanks for the suggestion. Addressed in 42b4bb4.