i18n (DE): add 'install-and-setup' - #14296
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
randomguy-2650
left a comment
There was a problem hiding this comment.
Left lots of nits that I found.
| title: Astro installieren | ||
| sidebar: | ||
| label: Installation | ||
| description: "So installierst du Astro und startest ein neues Projekt." |
There was a problem hiding this comment.
I don’t like how this is written for some reason…
In my opinion, my suggestion is probably not good either but could maybe be used to improve the translation:
---
description: "Wir zeigen dir, wie man Astro installiert und ein neues Projekt startet."
---The current translation just sounds a bit “clickbaity” to me.
There was a problem hiding this comment.
I don't see any clickbait here, nor any reason not to keep the desc brief and to add an extra meta-level:
"Wir zeigen dir, wie man..." 🆚 "So..."
Style Guide Wir bleiben möglichst nah am englischen Originaltext.
There was a problem hiding this comment.
What about something like:
| description: "So installierst du Astro und startest ein neues Projekt." | |
| description: "Eine Anleitung zur Installation von Astro und zum Starten eines neuen Projekts." |
It's more passive so definitely less clickbait if you insist @randomguy-2650. IMHO all suggestions here and the original are fine as well 👍
|
|
||
| ## Browser‑Kompatibilität | ||
|
|
||
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. |
There was a problem hiding this comment.
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. | |
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. | |
Just in case for compatibility.
There was a problem hiding this comment.
There is no paragraph here in the original text
There was a problem hiding this comment.
I know but if for some reason the MDX parser’s behaviour changes in the future, this will make it still work.
There was a problem hiding this comment.
@randomguy-2650 I think if you look at the original text, it is intended to be in one line. I think @rdwz just separated both sentences to individual lines for readability, which will render as no newline, so I think it is correct as is, no empty line needed.
There was a problem hiding this comment.
One thing I would like to simplify though for readability, is:
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. | |
| Astro basiert auf Vite, welches standardmäßig Browser mit moderner JavaScript‑Unterstützung anvisiert. |
I personally like to use "welches" in such cases because it makes it less confusing with the variety of meanings of "das" in the German language (better readability).
| } | ||
| ``` | ||
|
|
||
| 7. Projektstruktur |
There was a problem hiding this comment.
| 7. Projektstruktur | |
| 7. Bereite die Projektstruktur vor. |
I don’t like list items where it’s just one word. @trueberryless
There was a problem hiding this comment.
However, this only shows the structure that has been created up to this point. No further preparation is required.
There was a problem hiding this comment.
But one word still feels weird to me. Maybe:
So soll die Projektstruktur aussehen.
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Thanks for the review. I have now left some conversations open and made some changes. I'm still not sure how to do PR reviews correctly. If I have broken any rules, please let me know what I need to do to get this done properly 🤓 |
randomguy-2650
left a comment
There was a problem hiding this comment.
Looks pretty good once the remaining stuff is resolved.
Other stuff if you’re bothered to read it
That will maybe wait if @trueberryless doesn’t give another opinion yet, but his “Sommerferien” will end in around September, I don’t really think we would wait till then if he is on his holiday right now but…?
|
And about the reviewing PRs thing, you have to go to the Files changed tab in the PR, click on the + icon when hovering over the line you want to review, and comment about it (if it’s just one, click on Comment, otherwise Start a review). To add a suggestion, click on the ± symbol enclosed in a file icon silhouette. It will automatically add the contents of the line and you can edit it to change it according to your suggestion in your mind. (Only applies if you clicked on Start a review:) Once you’re done commenting all of the proposed changes, you can click on the accent button labelled Review changes and pick if you want to Comment, Approve or Request changes to the PR. See the descriptions of each radio button for more information. There you go, that’s how you review a PR. Tip Use four or more backticks for fenced code blocks in Markdown to add fenced code block syntax in a code block. This is how you embed code block syntax inside a code block to demonstrate:
````markdown
Look at this code!
```javascript
console.log("I’m a line of code!");
```
```` |
|
Thanks @rdwz, a few links are broken here. Could you update them? |
There was a problem hiding this comment.
Thanks for the translation @rdwz!
No worries, I am not totally inactive during summer holidays. So I went through some already existing nit picks to give some opinions and guidance.
Some bigger points I want to highlight without dedicated line suggestions (because it would be too many):
-
It seems that some sentences went completely missing during the translation. I especially noticed that the many sentences in each step of the
"Manual installation"section was often completely forgotten. To give some examples: One, two, three, four, etc. Could you please "self-review" the translation and compare the original with your translation. We would like to make sure that all sentences get the honor of being translated 😅 -
I would like you to include full empty lines before and after each
<Steps>and</Steps>usage. The reason for this seemingly nitpicky suggestion is that we noticed some parser issues in the past, which completely ruined the layout (Discord). If you are not on the Discord yet and can't access the conversation, I can recommend joining of course. But just in case, here is a screenshot of the important info:
And would you do me a favour and rename the PR title to: i18n(de): translate install-and-setup.mdx
Otherwise the translation looks really solid.
| title: Astro installieren | ||
| sidebar: | ||
| label: Installation | ||
| description: "So installierst du Astro und startest ein neues Projekt." |
There was a problem hiding this comment.
What about something like:
| description: "So installierst du Astro und startest ein neues Projekt." | |
| description: "Eine Anleitung zur Installation von Astro und zum Starten eines neuen Projekts." |
It's more passive so definitely less clickbait if you insist @randomguy-2650. IMHO all suggestions here and the original are fine as well 👍
|
|
||
| ## Browser‑Kompatibilität | ||
|
|
||
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. |
There was a problem hiding this comment.
@randomguy-2650 I think if you look at the original text, it is intended to be in one line. I think @rdwz just separated both sentences to individual lines for readability, which will render as no newline, so I think it is correct as is, no empty line needed.
|
|
||
| ## Browser‑Kompatibilität | ||
|
|
||
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. |
There was a problem hiding this comment.
One thing I would like to simplify though for readability, is:
| Astro basiert auf Vite, das standardmäßig moderne Browser mit aktueller JavaScript‑Unterstützung anvisiert. | |
| Astro basiert auf Vite, welches standardmäßig Browser mit moderner JavaScript‑Unterstützung anvisiert. |
I personally like to use "welches" in such cases because it makes it less confusing with the variety of meanings of "das" in the German language (better readability).
| - tsconfig.json | ||
| </FileTree> | ||
|
|
||
| 8. Starte jetzt den Astro‑Entwicklungsserver und sieh dir die Live‑Vorschau deines Projekts an! |
There was a problem hiding this comment.
Let's add the link to our other docs page here as it is done in the original:
| 8. Starte jetzt den Astro‑Entwicklungsserver und sieh dir die Live‑Vorschau deines Projekts an! | |
| 8. [Starte jetzt den Astro‑Entwicklungsserver](/de/develop-and-build/#starte-den-astro-entwicklungsserver) und sieh dir die Live‑Vorschau deines Projekts an! |
German translation of the page 'install-and-setup'