Document Cloudflare binding build-time image optimization - #13848
Document Cloudflare binding build-time image optimization#13848Daedalus-Icarus wants to merge 5 commits into
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
alexanderniebuhr
added
the
merge-on-release
alexanderniebuhr
left a comment
alexanderniebuhr
left a comment
There was a problem hiding this comment.
Checked this against the implementation in withastro/astro#16194. The type signature and the opt-in/shorthand behavior descriptions match the code. One correction needed on the runtime default claim (inline suggestion below), plus two non-blocking notes.
|
Preview deployment ✅ Deployment complete!
|
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks Alex for handling this PR! I particularly appreciate this as I am not familiar with Cloudflare and every time the options change it confuses me even more. 😅
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot
left a comment
ArmandPhilippot
left a comment
There was a problem hiding this comment.
I left one last nit to simplify the type and a non-blocking question. Otherwise, it seems ready to me. Thank you both!
|
|
||
| export default defineConfig({ | ||
| adapter: cloudflare({ | ||
| imageService: { build: 'cloudflare-binding', runtime: 'cloudflare-binding' } |
There was a problem hiding this comment.
I noticed we still show build and runtime here. Have you changed your mind about removing runtime? It's not a problem if that's the case, I just want to make sure it wasn't marked as resolved by mistake.
There was a problem hiding this comment.
I think even if it is the default value, we should still be able to configure it. Maybe the code PR needs an update here.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
4 participants
Changes
imageServiceconfiguration for opting in to build-time image optimization with the Cloudflare Images binding.imageService: 'cloudflare-binding'keeps the existing runtime-only behavior.Related