Repository navigation
Conversation
Select locale-aware day, hour and week forms in expiry and reminder templates and the session duration error. Cover singular and plural values through real views, templates and model validation.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Mark the directory tree as text so the existing MD040 check passes. The original document fails the same linter locally and the labelled block passes.
This was referenced Nov 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Counted messages currently produce wording such as
1 days,1 hours, and1 weeks, and do not expose separate plural forms to translators.Use Django's existing plural support for refresh-token expiry, email-confirmation link expiry, inactive-member reminders, and the maximum workout-session duration error. Preserve the numeric placeholders, settings, and validation behavior. Add regression coverage and a changelog entry; leave translated catalogues to Weblate.
Related Issue(s)
Related to #2571 and the requested Django/Flutter string audit. This covers the Django strings only; the React/Weblate migration and target-language review remain separate.
This is the Django part of the same cross-repository issue. Companion PRs: Flutter #1408 for source/fallback counts and React #1343 for source placeholders and Weblate migration documentation. The three PRs can be reviewed and merged independently; the hosted migration and translation review remain pending.
Validation
All four new regression methods fail against the original production strings and pass with the fix, covering singular and plural counts through the real views, templates, and model validation.
Ruff check, format check, and
git diff --checkpass. The local environment uses Windows and Python 3.14.2. A static-files warning reports missing frontendnode_modulesin the isolated backend checkout.makemigrations --check --dry-run --settings=settings.cireports pre-existing drift in the exercises and gallery apps. The same drift was reproduced with the unchanged upstream model atdde740753e76dee89fcd5b20fbb02fd8513bfa04; this patch changes no model fields and adds no migrations.CI follow-up: the initial Markdown run failed MD040 on an existing unlabelled fence at
AGENTS.md:31. A one-line follow-up labels the directory tree astext. The original document fails markdownlint-cli 0.49.1 locally; the fixedAGENTS.mdandCHANGELOG.mdpass with Super-linter v9.0.0's Markdown configuration. No application code changed in this follow-up. The updated Markdown run, Ruff, CodeQL, and all three Python CI jobs now pass on commitf30c9d0f06b45a0216ce709771a26b6ecc292789.Please check that the PR fulfills these requirements
AI assistance was used for investigation, implementation, and test preparation. The changes and regression results were reviewed locally.