Add tests for footer social links - #4882
Open
amitha-m-joe wants to merge 1 commit into
Open
Conversation
- All 9/9 passing on BrowserStack (Chrome)
charanya-QA
reviewed
Jul 28, 2026
Contributor
There was a problem hiding this comment.
@amitha-m-joe : 1) Can you Please remove the driver.pause(waitTime) since you are already using waitforDisplayed already
2) Also if you could add the repeated steps of all the test case before each?beforeEach(async () => {
await FooterSocialLinksPage.load();
await FooterSocialLinksPage.scrollToFooter();
await FooterSocialLinksPage.facebookLink.waitForDisplayed({
timeout: waitTime,
});
});
then each test would have only assertions
3) TC-011 open a new tab but doesn't closes it. When we execute all the modules this would be a problem , Can you pls close that too?
rest all looks good ! Thanks for attaching the screenshot of browserstack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Coverage: icon visibility, platform existence, href correctness (Facebook/Instagram/Twitter), target="_blank" behavior, new-tab-stays-open, hover cursor state, broken image check.