fix(tempo): respect token metadata batching config - #4951
Conversation
|
@struong is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 5e25f5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
commit: |
6861456 to
6c89c6c
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Superseded by #4956, which uses a branch in |
Pull request was closed
Summary
Updates Tempo token metadata reads to honor explicit client multicall configuration while preserving deployless Multicall3 as the action's default.
Motivation
Zone clients cannot execute deployless contract-creation
eth_callrequests. Explicitly disabling client multicall should allowtoken.getMetadatato use ordinary contract reads without changing the default behavior for existing Tempo clients.Changes
readContractcalls when the client explicitly configures multicall behavior.Testing
pnpm test src/tempo/actions/token.test.ts --run— 76 passed, 1 existing skip.pnpm check:typespnpm build:typesVITE_TEMPO_ZONES=true pnpm test src/tempo/actions/zone.test.ts --run; the local Zone container exited before tests because the configured dev key did not ownZoneFactory.