Skip to content

fix(tempo): respect token metadata batching config - #4951

Closed
struong wants to merge 5 commits into
wevm:mainfrom
struong:struong/fix-zone-token-metadata
Closed

fix(tempo): respect token metadata batching config#4951
struong wants to merge 5 commits into
wevm:mainfrom
struong:struong/fix-zone-token-metadata

Conversation

@struong

@struong struong commented Aug 3, 2026

Copy link
Copy Markdown
Member

Summary

Updates Tempo token metadata reads to honor explicit client multicall configuration while preserving deployless Multicall3 as the action's default.

Motivation

Zone clients cannot execute deployless contract-creation eth_call requests. Explicitly disabling client multicall should allow token.getMetadata to use ordinary contract reads without changing the default behavior for existing Tempo clients.

Changes

  • Preserved deployless metadata multicall when the client does not specify a multicall setting.
  • Used concurrent readContract calls when the client explicitly configures multicall behavior.
  • Preserved pathUSD fields, declared-token overrides, logo URI fallback, and deterministic required-field errors.
  • Added focused Tempo and Zone coverage plus a patch changeset.

Testing

  • pnpm test src/tempo/actions/token.test.ts --run — 76 passed, 1 existing skip.
  • pnpm check:types
  • pnpm build:types
  • Attempted VITE_TEMPO_ZONES=true pnpm test src/tempo/actions/zone.test.ts --run; the local Zone container exited before tests because the configured dev key did not own ZoneFactory.

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

@struong is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5e25f5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/viem@4951

commit: 5e25f5e

@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/viem@4951

commit: 8a41b77

@struong
struong force-pushed the struong/fix-zone-token-metadata branch from 6861456 to 6c89c6c Compare August 3, 2026 20:39
@struong
struong marked this pull request as ready for review August 3, 2026 20:55
@jxom

jxom commented Aug 3, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5e25f5efa1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jxom
jxom enabled auto-merge (squash) August 3, 2026 22:14

struong commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Superseded by #4956, which uses a branch in wevm/viem so CI can access repository secrets.

@struong struong closed this Aug 4, 2026
auto-merge was automatically disabled August 4, 2026 17:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants