Conversation
Unlike Chrome and Firefox, Safari has no gate in shimMaxMessageSize, so the setRemoteDescription wrapper is installed unconditionally. When pc.sctp is native the getter it feeds is not installed, which means the value parsed out of every remote description can not be read by anyone -- and it disagrees with what apps actually see (65536 vs the native 262144 in WebKit 26). Gate on the presence of the attribute rather than a version so old Safari keeps the shim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike Chrome and Firefox, Safari has no gate in shimMaxMessageSize, so the setRemoteDescription wrapper is installed unconditionally. When pc.sctp is native the getter it feeds is not installed, which means the value parsed out of every remote description can not be read by anyone -- and it disagrees with what apps actually see (65536 vs the native 262144 in WebKit 26).
Gate on the presence of the attribute rather than a version so old Safari keeps the shim.