Properly escape JS values in head_insert template - #1003
Open
ato wants to merge 1 commit into
Open
Conversation
Removes the custom tojson filter in favor of the standard Jinja one which is actually safe in a HTML context. This stops us using `ujson` but I wouldn't expect it's providing a worthwhile speedup for these small values anyway. Removes the dangerous `autoescape false`. Instead uses the `tojson` filter for the JavaScript values and the `safe` filter for the trusted HTML of the custom banner. Supercedes #990.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the custom tojson filter in favor of the standard Jinja one which is actually safe in a HTML context (json.dumps doesn't escape
</script>). This stops us usingujsonbut I wouldn't expect it's providing a worthwhile speedup for these small values anyway.Removes the dangerous
autoescape false. Instead uses thetojsonfilter for the JavaScript values and thesafefilter for the trusted HTML of the custom banner.Motivation and Context
The lack of escaping is unsafe and is vulnerable to a malicious WARC file. See discussion in #990.
Types of changes
Checklist: