feat: expose blockchain id constants#135
Draft
wyf027 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web3Data.Fix/Approach
src/constants.js.Web3Dataclass, matching the issue example (Web3Data.BLOCKCHAIN_ID_ETHEREUM_MAINNET).Verification
npx ava test/web3data.test.js --match='Web3data exposes blockchain id constants as public class properties' -- --mode replayfailed before the implementation withundefinedforWeb3Data.BLOCKCHAIN_ID_ETHEREUM_MAINNET.npx ava test/web3data.test.js --match='Web3data exposes blockchain id constants as public class properties' -- --mode replaypassed after the implementation:1 test passed.npm testpassed:181 tests passed,52 tests skipped.npm run buildpassed and regenerateddist/web3data.min.js.git diff --checkpassed.Notes
CONTRIBUTING.mdasks contributors to sign a CLA. I cannot sign legal documents on behalf of anyone, so a CLA check may remain pending until an authorized contributor handles it.Related issue
Fixes #68