Revise performance timing entries' names and descriptions - #4278
Conversation
tunetheweb
left a comment
There was a problem hiding this comment.
Mostly LGTM but if we're capitalising some, then I'd capitalise them all. The specs mostly treat these as proper nouns (though not in all places I've noticed!).
And similarly I'd suggest adding "peformance entries" consistently.
I've also suggested changes to Visibility State and Resource Timing to make them clearer.
| @@ -1,5 +1,5 @@ | |||
| name: Element timing | |||
There was a problem hiding this comment.
| name: Element timing | |
| name: Element Timing performance entries |
| @@ -1,5 +1,5 @@ | |||
| name: Layout instability | |||
There was a problem hiding this comment.
| name: Layout instability | |
| name: Layout Instability performance entries |
| @@ -1,5 +1,5 @@ | |||
| name: Navigation timing | |||
There was a problem hiding this comment.
| name: Navigation timing | |
| name: Navigation Timing performance entries |
| @@ -1,5 +1,5 @@ | |||
| name: Paint timing | |||
There was a problem hiding this comment.
| name: Paint timing | |
| name: Paint Timing performance entries |
| @@ -1,5 +1,5 @@ | |||
| name: Resource timing | |||
There was a problem hiding this comment.
| name: Resource timing | |
| name: Resource Timing performance entries |
| @@ -1,5 +1,5 @@ | |||
| name: Soft navigation performance entries | |||
There was a problem hiding this comment.
| name: Soft navigation performance entries | |
| name: Soft Navigation performance entries |
| @@ -1,5 +1,5 @@ | |||
| name: Resource timing | |||
| description: "`PerformanceResourceTiming` entries report when network events happen while loading a resource, such as when connections start and end. You can use this information to measure loading times." | |||
| description: A `PerformanceResourceTiming` performance entry records when a network event happens while loading a resource, such as when a connection starts and ends. You can use this information to measure loading times. | |||
There was a problem hiding this comment.
| description: A `PerformanceResourceTiming` performance entry records when a network event happens while loading a resource, such as when a connection starts and ends. You can use this information to measure loading times. | |
| description: A `resource` performance entry records network event timings, such as when a connection starts and ends or loading time, for resources requested by a page. |
| @@ -1,5 +1,5 @@ | |||
| name: Page visibility state | |||
There was a problem hiding this comment.
| name: Page visibility state | |
| name: Page Visibility State Entry performance entry |
I think this is especially important to rename to differentiate it from page-visibility.yml (which is related but different - one just gets the current state, the other monitors for changes).
A follow up to #4237.