Repository navigation
fix(server-core): normalize encoded render route paths - #9036
Merged
GiveMe-A-Name merged 1 commit intoOct 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
GiveMe-A-Name
approved these changes
Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Requests such as
/page%5Ename.htmlreach Hono's render middleware but return 404 because the inner render router matches the raw encoded pathname. Reuse Hono'sgetPath()for the render lookup so both routers use the same pathname normalization, while preserving encoded separators and explicitmatchPathnamerewrites.Add regression coverage for SSR/CSR, encoded characters and subpaths, malformed escapes, percent encoding, dynamic parameters, and direct rendering. Includes a patch changeset.
Related Links
Fixes #9034.
Failing Rslib Eco-CI job
Local validation
pnpm prepare-build: passed.pnpm test:ut: 127 files passed, 766 tests passed, 3 skipped.pnpm --filter @modern-js/server-core test: 116 tests passed on both Node 24.20.0 and Node 22.16.0.pnpm checkfor changed files andchangeset status --since=origin/main: passed.Checklist
pnpm run change.