Repository navigation
fix(cli): upgrade yargs for Node.js 26 compatibility - #3203
Merged
Merged
Conversation
yuyutaotao
approved these changes
Sep 29, 2026
EAGzzyCSL
force-pushed
the
zzy/fix-test-yargs-node26
branch
from
September 29, 2026 11:03
5f039a9 to
2bbdfde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
midscene-test createfails on Node.js 26.7.0 withrequire is not defined in ES module scopewhen loading yargs 17.7.2's extensionless CommonJS entry inside itstype: modulepackage.Upgrade the pinned yargs dependency in
@midscene/testand@midscene/clito 17.7.3 and update the lockfile. This patch release routesrequire('yargs/yargs')toyargs.cjs, fixing the incompatibility without a major-version upgrade. See yargs/yargs#2509 and yargs/yargs#2514.Validation:
pnpm run lintpnpm exec nx run-many --target=build --projects=@midscene/test,@midscene/clipnpm exec nx test @midscene/test— 388 tests passed.pnpm exec nx run-many --target=test --projects=@midscene/test,@midscene/cli— CLI tests passed; Test initially failed due to stale Core build output and passed after rebuilding dependencies with the commands above.pnpm --filter @midscene/test exec vitest --run --config vitest.e2e.config.ts tests/e2e/create-cli.test.ts -t 'creates a web project through the built CLI'— local smoke test passed. This test is an uncommitted local verification and is not included in this dependency-only PR.