Repository navigation
Conversation
quanru
previously approved these changes
Oct 7, 2026
quanru
dismissed
their stale review
October 7, 2026 01:53
Withdrawn at the repository owner's request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When parsing an auto-glm
finish(...)action,extractValueAfteralready strips the closing"), but the parser then removed one more trailing)unconditionally. A message that ends with a parenthesis, such asfinish(message="Deleted 3 items (all done)"), was returned asDeleted 3 items (all done. The extra)is now only stripped when the response did not end with"), and a test covers this case.Validation
npx rstest run tests/unit-test/model-adapter/auto-glm/planning-action-parser.test.tsinpackages/core(new test fails before the change, passes after)npx rstest run tests/unit-test/model-adapter/auto-glminpackages/core(the 4prompt.test.tssnapshot mismatches are date/timezone related and also fail onmainlocally)npx nx build @midscene/corepnpm run type-check:tests(packages/corepasses)pnpm run lint