Repository navigation
feat(ios): support gateway WDA base URLs - #3187
Merged
Merged
Conversation
Deploying midscene with
|
| Latest commit: |
0a201e8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddf63d6a.midscene.pages.dev |
| Branch Preview URL: | https://feat-ios-wda-base-url-3180.midscene.pages.dev |
EAGzzyCSL
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wdaBaseUrlso iOS can reach WebDriverAgent through HTTPS gateways and arbitrary path prefixes.wdaBaseUrlwithwdaHostorwdaPortinstead of silently applying precedence.wdaMjpegUrlfor remote HTTP(S) MJPEG streams, with URL/port conflict validation, HTTPS Playground proxying, and safe fallback to screenshot polling.wdaBaseUrl,wdaMjpegUrl, and optional session references through environment variables. Keep gateway paths and tokens out of recordings and exports.Closes #3180.
Validation
pnpm run lintpnpm exec nx build @midscene/testpnpm exec nx run-many -t test -p @midscene/webdriver @midscene/core @midscene/ios @midscene/test --parallel=2pnpm exec nx run-many -t test -p @midscene/ios @midscene/test --parallel=2pnpm exec nx run-many -t build -p @midscene/ios @midscene/test --parallel=2pnpm exec nx test @midscene/iospnpm exec nx build @midscene/iospnpm exec nx run-many -t test -p @midscene/ios @midscene/playground @midscene/test --parallel=2pnpm exec nx run-many -t build -p @midscene/ios @midscene/playground @midscene/test --parallel=2pnpm exec nx test @midscene/playgroundpnpm exec nx build @midscene/sharedpnpm exec nx test studiopnpm exec nx build studiopnpm exec rstest run tests/unit-test/platform-session-manager.test.ts(frompackages/ios)pnpm exec vitest run tests/playground-selectors.test.ts tests/studio-recorder.test.ts(fromapps/studio)pnpm run type-check:testspnpm exec rstest run tests/unit/mjpeg-stream-handler.test.ts(frompackages/playground)AI_TEST_TYPE=iOS pnpm exec rstest run tests/ai/ios-simulator-smoke.test.ts(frompackages/ios; live tests skip locally without the CI simulator flag)The gateway URL flow is covered with mocked HTTP requests for both
/code/wdaand/wda/codeprefix layouts. Conflict checks cover the SDK, Playground, and CLI tools. MJPEG tests cover independent HTTPS URLs, legacy HTTP streams, URL validation, and polling fallback. Studio tests cover gateway paths on the same host, reconnection values, recording history isolation, and safe YAML export. PR CI runs a real iOS Simulator and WDA through both direct host/port and a local path-prefixed HTTP gateway. A physical iPhone or external HTTPS gateway was not available for device validation.