Conversation
|
I think it's important to note @outdooracorn was suggesting either add the try-catch or use What we learnt so far is that testing if adding either of these two things makes the situation more robust is harder. If we use We also learnt that by default notifications use |
Make it possible to sent a list of excluded emails via the constructor Bug: T432211
We had a look at this and realised that this table is for notifications about Wikis to be sent to managers. It doesn't seem to be useful from the perspective of just Users entirely independent of Wikis. For example, it really needs a We did discuss if we ought to implement a new table to track these changes but figured that this would add yet more time when we want to prioritise getting these mails sent out and we also want to stop thinking about this topic in general. |
This adds additional try-catch logic to make running this more robust.
It specifically adds a test for a real error we saw caused by attempting to email
a malformed email address.
It does not record to the DB successful emails but it does add log output that
will be persisted in GCE for longer than the mailgun logs.
Bug: T432211