Imu output enabled - #1
Open
wltry wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds timestamp-synchronized raw IMU publishing and an optional Madgwick orientation pipeline.
Changes:
- Publishes RIP IMU batches as ROS
sensor_msgs/Imu. - Uses RIP timestamps for sonar outputs.
- Adds Madgwick filter launch and configuration files.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
waterlinked_sonar_3d15/sonar_node.py |
Adds IMU control, publishing, timestamps, and diagnostics. |
README.md |
Documents IMU support and topic. |
launch/sonar_imu_orient.launch.py |
Launches the sonar and Madgwick filter. |
config/pinchy_params.yaml |
Configures the IMU topic. |
config/imu_filter_params.yaml |
Defines Madgwick filter settings. |
config/default_params.yaml |
Configures the default IMU topic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Added IMU output to sonar_node/imu topic.
Also added a launch file for running imu_filter_madgwick to get pose estimate out of the raw imu data.
Modified the pointcloud/image publishers so that timestamp from the RIP package header is used, to keep in sync with the IMU message timestamps.
Testing