Skip to content

Imu output enabled - #1

Open
wltry wants to merge 5 commits into
mainfrom
imu_output_enabled
Open

Imu output enabled#1
wltry wants to merge 5 commits into
mainfrom
imu_output_enabled

Conversation

@wltry

@wltry wltry commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Changes Made

Added IMU output to sonar_node/imu topic.
Also added a launch file for running imu_filter_madgwick to get pose estimate out of the raw imu data.

Modified the pointcloud/image publishers so that timestamp from the RIP package header is used, to keep in sync with the IMU message timestamps.

Testing

colcon build && source install/setup.bash
ros2 launch waterlinked_sonar_3d15 sonar_imu_orient.launch.py

@wltry wltry self-assigned this Aug 11, 2026
@wltry
wltry requested a review from tholok97 August 20, 2026 13:54
@wltry
wltry marked this pull request as ready for review August 20, 2026 13:54
@wltry
wltry requested a balanced review from Copilot August 21, 2026 09:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds timestamp-synchronized raw IMU publishing and an optional Madgwick orientation pipeline.

Changes:

  • Publishes RIP IMU batches as ROS sensor_msgs/Imu.
  • Uses RIP timestamps for sonar outputs.
  • Adds Madgwick filter launch and configuration files.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
waterlinked_sonar_3d15/sonar_node.py Adds IMU control, publishing, timestamps, and diagnostics.
README.md Documents IMU support and topic.
launch/sonar_imu_orient.launch.py Launches the sonar and Madgwick filter.
config/pinchy_params.yaml Configures the IMU topic.
config/imu_filter_params.yaml Defines Madgwick filter settings.
config/default_params.yaml Configures the default IMU topic.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread waterlinked_sonar_3d15/sonar_node.py Outdated
Comment thread waterlinked_sonar_3d15/sonar_node.py
Comment thread README.md
Comment thread launch/sonar_imu_orient_demo.launch.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants