Repository navigation
fix(cli): restore guest Wasm C API imports - #2
Merged
Merged
Conversation
Register the existing Wasm C API hook on the WASIX Machine used by wasmer run. Restore the wasm-c-api feature in standard release builds and the guest smoke test’s success assertion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The WASIX v2 CLI migration dropped registration for the guest
wasm_c_api_v0imports. Packages that embed QuickJS Edge.js could fail during instantiation onwasm_memory_size.Register the existing
WasmCapiRuntimeHooksinRun::machinefor both direct WASIX guests and package commands. Restore thewasm-c-apifeature in the standard release recipes, including V8-only, and restore the pinned C guest's success assertion.Validation
cranelift,wasm-c-apivia mbx atbef7e60a86.wasm-c-api ok. The existing WAT fixture exited 0. Both fixtures reproduce the missing import at the pinned base.mbx fmt --all -- --checkandgit diff --checkpassed.wasixv2::testshook tests passed through mbx. The filtered CLI integration testswasmer_run_wasix_wasm_c_api_guestandrun_wasixv2_package_command_that_does_not_instantiate_is_an_errorpassed against the pinned binary.--no-default-features --features v8,wasm-c-api.make lintstopped at missingyamlfmt. CI's whole-workspace Taplo also found formatting differences in the unchanged WASIX API and dylink manifests.Candidate SHA-256 is
a4d17068b7ef22fe7ff80dc250329de538b6f67b9dee206fa3f7a6204281aa83. OpenAI Codex authored the functional commit and the formatting-only follow-up. The performance binary was built before the formatting follow-up, whose parsed manifest is identical.