Skip to content

napi_refs teardown fix - #25

Merged
sadhbh-c0d3 merged 1 commit into
mainfrom
napi_qjs_teardown_issues
May 19, 2026
Merged

sadhbh-c0d3 merged 1 commit into
mainfrom
napi_qjs_teardown_issues

Conversation

@sadhbh-c0d3

Copy link
Copy Markdown
Contributor

When napi_env was preparing for teardown, it would drain all napi_ref(s) from allocator and destruct them. However this was causing assertion failures later. Fix changes that napi_env teradown clears napi_ref(s) for teardown, without removing them from allocator.

@sadhbh-c0d3
sadhbh-c0d3 requested a review from syrusakbary May 19, 2026 02:10
@sadhbh-c0d3
sadhbh-c0d3 merged commit c21109c into main May 19, 2026
8 checks passed
@sadhbh-c0d3
sadhbh-c0d3 deleted the napi_qjs_teardown_issues branch May 19, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants