Skip to content

NAPI standalone build without Edge dependency (Fixes: No tests were found) - #24

Merged
syrusakbary merged 3 commits into
mainfrom
napi_standalone_build
May 19, 2026
Merged

syrusakbary merged 3 commits into
mainfrom
napi_standalone_build

Conversation

@sadhbh-c0d3

@sadhbh-c0d3 sadhbh-c0d3 commented May 18, 2026 •

Copy link
Copy Markdown
Contributor
  • Previously NAPI wouldn't build if it wasn't checked out into edgejs/napi subdirectory.
  • Previously tests wouldn't run in GitHub.
  • Release and Debug builds and tests enabled.
  • Added test for async of
  • Dsiabled SandboxGlobalThisAndMarkerAreNotEnumerableForDeepFreeze test

Because build system was incorrectly setup, NAPI would build and appear green in GtiHub, but if we inspected actions, we would see tests were not run. This fixes the problem.

Because tests weren't run in GitHub, we wouldn't know that test was failing for both quickjs and v8. Disabled this test.

@sadhbh-c0d3
sadhbh-c0d3 marked this pull request as draft May 18, 2026 22:16
@sadhbh-c0d3 sadhbh-c0d3 changed the title NAPI standalone build without Edge dependency NAPI standalone build without Edge dependency (Fixes: No tests were found) May 18, 2026
@sadhbh-c0d3
sadhbh-c0d3 marked this pull request as ready for review May 18, 2026 22:42
@sadhbh-c0d3
sadhbh-c0d3 requested a review from syrusakbary May 18, 2026 23:06
@syrusakbary
syrusakbary merged commit 84ca277 into main May 19, 2026
8 checks passed
@sadhbh-c0d3
sadhbh-c0d3 deleted the napi_standalone_build branch May 19, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants