Repository navigation
fix: store metadata + multipart parts in a reserved dir on the volume - #12
Merged
Merged
Conversation
Author
|
@arshia CI failure appears to be due to new cargo registry in some way, afaict |
Arshia001
approved these changes
Jul 16, 2026
|
@kilyanni that's what happens when people don't pin their prerelease versions and a breaking change comes in! Now, this code will no longer build properly. We should rework the Cargo.toml file by removing string matches ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Edge volumes the S3 fs-root is read-only (the volume is mounted at the bucket), but the fs backend wrote per-object metadata sidecars and in-flight multipart parts at the fs-root. So every
PutObject500'd after the object was already written, and multipart was unusable.Fix
Store both inside the bucket instead, under a reserved
.wasmer-s3/dir (on the writable volume): metadata →.wasmer-s3/meta/, parts →.wasmer-s3/mpu/.The prefix is carved out of the object keyspace (like MinIO's
.minio.sys/): user keys under it are rejected (AccessDenied), read as absent (NoSuchKey), and hidden fromLIST.Unlike previously, metadata is now written before the object, so a metadata failure is a clean error rather than a stored object + 500. This means we fail-fast, rather than waiting for the full upload to finish (and leaving a torn state) if there are issues with metadata writing.