Skip to content

fix: store metadata + multipart parts in a reserved dir on the volume - #12

Merged
kilyanni merged 1 commit into
masterfrom
fix/reserved-dir-metadata-multipart
Jul 16, 2026
Merged

kilyanni merged 1 commit into
masterfrom
fix/reserved-dir-metadata-multipart

Conversation

@kilyanni

Copy link
Copy Markdown

On Edge volumes the S3 fs-root is read-only (the volume is mounted at the bucket), but the fs backend wrote per-object metadata sidecars and in-flight multipart parts at the fs-root. So every PutObject 500'd after the object was already written, and multipart was unusable.

Fix

Store both inside the bucket instead, under a reserved .wasmer-s3/ dir (on the writable volume): metadata → .wasmer-s3/meta/, parts → .wasmer-s3/mpu/.

The prefix is carved out of the object keyspace (like MinIO's .minio.sys/): user keys under it are rejected (AccessDenied), read as absent (NoSuchKey), and hidden from LIST.

Unlike previously, metadata is now written before the object, so a metadata failure is a clean error rather than a stored object + 500. This means we fail-fast, rather than waiting for the full upload to finish (and leaving a torn state) if there are issues with metadata writing.

@kilyanni
kilyanni requested a review from Copilot July 15, 2026 16:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kilyanni

Copy link
Copy Markdown
Author

@arshia CI failure appears to be due to new cargo registry in some way, afaict

@kilyanni
kilyanni merged commit f8301bd into master Jul 16, 2026
2 of 3 checks passed
@kilyanni
kilyanni deleted the fix/reserved-dir-metadata-multipart branch July 16, 2026 12:20
@Arshia001

Copy link
Copy Markdown

@kilyanni that's what happens when people don't pin their prerelease versions and a breaking change comes in! Now, this code will no longer build properly. We should rework the Cargo.toml file by removing string matches (version = "=x.y.z.") and also eliminating the patch section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants