Implement mappings for popover=hint - #2716
Closed
keithamus wants to merge 2 commits into
Closed
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Hi @keithamus Any chance you could open this PR from a branch that's on w3c/aria? We've now implemented a new preview system but because we're using secrets, they do not get passed to forks by default. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2715
This introduces extra logic which changes the mappings for
popoverwhen it is in the "hint" state. It does so by defining a new concept of "plain content" and "rich content", then in the popover & command tables, it uses those to determine if a popover=hint should be DETAILS or DESCRIBED_BY.And a few other todo items (delete this section after performing them):
spec:<spec_name>label. If you don't have privileges to do this, editors will do it for you.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.