add server::$raw_prepend_ssl - #1710
Merged
Merged
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #1422 still open and no viable ideas presented for dealing with the singularly allowed occurance of
reuseportfor anyip:port quiccombination, there is a valid reason to inject raw directives only into the sslserver{}block.This applies mostly to scenarios where you want the
http(plaintext)server{}block to operate autonomously without a forcedhttpsredirect.Without this separate parameter only for the ssl
server {}block, you would have to fully duplicate thehttpandhttpsserver{}resources and then only add the desired ssl-only stuff into theraw_prependparameter of thehttpsserver{}resource, which is incredibly cumbersome and error-prone.Duplicating such configuration blocks is just bad practice, annoying and should be avoided at all costs.
Thus I consider adding an additional
raw_prepend_sslparameter as an acceptable workaround that might even have further use cases that I'm not even aware of at this time.