Skip to content

Replace crash with graceful error handling in ListRequirement.unsatis… #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IB-Mustafa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Replace crash with graceful error handling in ListRequirement.unsatis… #1999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions volatility3/framework/configuration/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,11 @@ def unsatisfied(
elif value is None:
context.config[config_path] = []
if not isinstance(value, list):
# TODO: Check this is the correct response for an error
raise TypeError(f"Unexpected config value found: {repr(value)}")
vollog.log(
constants.LOGLEVEL_V,
f"TypeError - Unexpected config value found, expected list: {repr(value)}",
)
return {config_path: self}
if not (self.min_elements <= len(value)):
vollog.log(
constants.LOGLEVEL_V,
Expand Down