Skip to content

Vivo 1954#7

Open
michel-heon wants to merge 2 commits into
vivo-project:mainfrom
MichelHeon:VIVO-1954
Open

Vivo 1954#7
michel-heon wants to merge 2 commits into
vivo-project:mainfrom
MichelHeon:VIVO-1954

Conversation

@michel-heon

@michel-heon michel-heon commented Jan 29, 2021

Copy link
Copy Markdown
Member

Issue ref: VIVO-1954

Adding content in readme.txt and adjustment of the base-uri of sample-data.orig.ttl .

Feel free to improve the text

Comment thread i18n/Readme.txt
sample-data:n1467 rdfs:label "Professor"@en-US .
by
sample-data:n1467 rdfs:label " Professeur"@en-BE ;
)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add here the forth points and invite people to contribute, i.e. create a pull request in the case they believe their localization of sample data might be useful for the community?

Comment thread i18n/Readme.txt
by
sample-data:n1467 rdfs:label " Professeur"@en-BE ;
)
-- End of text -- No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this annotation for the end of the file is necessary.

Comment thread i18n/Readme.txt

The files are divided into two series: *-orig.ttl and *-i18n*.ttl and they
correspond respectively to a use in a first instance of VIVO 1.11 not
including internationalization and the VIVO 1.12 version

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIVO 1.12+ version?

Comment thread i18n/Readme.txt
liguistic context (e.g.:
sample-data:n1467 rdfs:label "Professor"@en-US .
by
sample-data:n1467 rdfs:label " Professeur"@en-BE ;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a typo, fr-BE instead of en-BE

@chenejac
chenejac requested a review from brianjlowe December 20, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants