Skip to content

Feature/integration model#504

Open
ivanmrsulja wants to merge 3 commits into
vivo-project:mainfrom
ivanmrsulja:feature/integration-model
Open

Feature/integration model#504
ivanmrsulja wants to merge 3 commits into
vivo-project:mainfrom
ivanmrsulja:feature/integration-model

Conversation

@ivanmrsulja

@ivanmrsulja ivanmrsulja commented Dec 17, 2025

Copy link
Copy Markdown
Member

Issues: 4074, 4075

linked VIVO PR: 4125

What does this pull request do?

Added support for integration model graph, where integration metadata (access tokens, push history, utility metadata) can be stored for various external platforms.

What's new?

  • api/src/main/java/edu/cornell/mannlib/vitro/webapp/servlet/setup/ConfigurationModelsSetup.java
  • api/src/main/java/edu/cornell/mannlib/vitro/webapp/modules/tripleSource/ConfigurationTripleSource.java
  • api/src/main/java/edu/cornell/mannlib/vitro/webapp/modelaccess/ModelNames.java

How should this be tested?

This should be tested in conjunction with corresponding VIVO PR that introduces Orcid Member API integration for push workflows. It uses this model for integration metadata storage, if it works as expected, so does this.

Interested parties

@chenejac

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Java

@chenejac chenejac added the VIVO ORCID Pull request is linked with VIVO ORCID project label Feb 3, 2026
@chenejac
chenejac requested review from chenejac and litvinovg April 30, 2026 14:54
@chenejac chenejac mentioned this pull request May 3, 2026
Comment thread webapp/src/main/webapp/css/vitro.css Outdated
Comment on lines +546 to +554

.mt-5 {
margin-top: 3.5rem;
}

.section-title-small {
margin-bottom: 0rem !important;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of those lines? Why !important? Can that be changed in themes if it is defined as here? Morover, ORCID integration is VIVO specific task, not sure why css configuration is in Vitro code.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consulted @milospp and he suggested to move this CSS to VIVO's wilma.css, so I did that. Also, !important is not needed anymore because, after moving the code, load order is as it should be.

@chenejac chenejac removed the VIVO ORCID Pull request is linked with VIVO ORCID project label May 28, 2026
@ivanmrsulja
ivanmrsulja force-pushed the feature/integration-model branch from a013710 to a7f782a Compare June 15, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants