Fix onSelectItem handler in editable chip skill template#5328
Merged
manuelblum merged 2 commits intoMar 16, 2026
Conversation
…parameter Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on comet-crud Agent skills implementation
Fix Mar 16, 2026
onSelectItem handler in editable chip skill template
manuelblum
approved these changes
Mar 16, 2026
manuelblum
marked this pull request as ready for review
March 16, 2026 20:35
manuelblum
added a commit
that referenced
this pull request
Mar 24, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
vps-manuel-blum
pushed a commit
that referenced
this pull request
Jul 20, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onSelectItemcallback in theenum-02-editable-chip.mdtemplate incorrectly used destructuring syntax({enumFieldName}) => ..., treating the parameter as an object — butonSelectItemprovides a single enum value (string union). The mutation variables also relied on shorthand notation that would only work if the parameter name matched the field name exactly.Changes
enum-02-editable-chip.md: Replace destructuring parameter with a single(value)argument and explicitly map mutation variables as{enumFieldName}: valueBefore:
After:
This aligns the template with the concrete
LocationStatusexample already present in the same file.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.