Skip to content

Fix ambiguous GraphQL variable placeholder in mutation template#5327

Closed
manuelblum with Copilot wants to merge 12 commits into
com-2900/add-crud-skillsfrom
copilot/sub-pr-5323
Closed

Fix ambiguous GraphQL variable placeholder in mutation template#5327
manuelblum with Copilot wants to merge 12 commits into
com-2900/add-crud-skillsfrom
copilot/sub-pr-5323

Conversation

Copilot AI commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

The mutation template in enum-02-editable-chip.md used ${enumFieldName} for GraphQL variable references, which is visually ambiguous — it reads like a JS template literal where the entire ${enumFieldName} token gets replaced by status, dropping the $ prefix and producing invalid GraphQL.

Change

  • enum-02-editable-chip.md: Changed ${enumFieldName}{$enumFieldName} in both the variable declaration and input reference of the mutation template

The {$enumFieldName} placeholder follows the file's existing {placeholder} convention with $ embedded, making it unambiguous that the expansion includes the GraphQL variable prefix:

# Before (ambiguous — ${...} looks like a single replaceable token)
mutation Update{EntityName}{EnumName}($id: ID!, ${enumFieldName}: {EnumName}!) {
    {updateMutation}(id: $id, input: { {enumFieldName}: ${enumFieldName} }) {

# After (clear — {$enumFieldName} expands to $status, {enumFieldName} expands to status)
mutation Update{EntityName}{EnumName}($id: ID!, {$enumFieldName}: {EnumName}!) {
    {updateMutation}(id: $id, input: { {enumFieldName}: {$enumFieldName} }) {

This matches the concrete example already present in the file ($status: LocationStatus! / input: { status: $status }).


💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

manuelblum and others added 11 commits March 13, 2026 13:37
- Fix sort variable to use array in grid-02-row-reordering reference
- Change enum field defaults: SelectField (<=4), AutocompleteField (>4), RadioGroupField only on request
- Add useAutocompleteOptions helper reference for translatable enum skill
- Update enum-04-autocomplete-field to point to helper reference instead of "ask the user"
- Add GPG signing fallback hint to comet-crud error recovery
…electFieldProps (#5326)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
…array form state (#5324)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback on 'add comet-crud Agent skills' PR Fix ambiguous GraphQL variable placeholder in mutation template Mar 16, 2026
Copilot AI requested a review from manuelblum March 16, 2026 20:04
@manuelblum
manuelblum force-pushed the com-2900/add-crud-skills branch from ab9885b to 8ffb076 Compare March 24, 2026 10:31
@manuelblum manuelblum closed this Apr 9, 2026
@johnnyomair
johnnyomair deleted the copilot/sub-pr-5323 branch April 9, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants