Skip to content

Fix CheckboxListField skill template: use CheckboxListFieldProps and array form state#5324

Merged
manuelblum merged 2 commits into
com-2900/add-crud-skillsfrom
copilot/sub-pr-5323
Mar 16, 2026
Merged

Fix CheckboxListField skill template: use CheckboxListFieldProps and array form state#5324
manuelblum merged 2 commits into
com-2900/add-crud-skillsfrom
copilot/sub-pr-5323

Conversation

Copilot AI commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

The enum-06-checkbox-list-field.md skill template was incorrectly typed — it imported SelectFieldProps instead of CheckboxListFieldProps, and defined FormState as a single enum value rather than an array.

Changes

  • Import: SelectFieldPropsCheckboxListFieldProps from @comet/admin
  • FormState type: GQL{EnumName}GQL{EnumName}[] (consistent with "Form state is an array" description)
  • Props type: Omit<SelectFieldProps<{EnumName}FormState>, "options">Omit<CheckboxListFieldProps<GQL{EnumName}>, "options"> (passes base value type; CheckboxListFieldProps<Value> internally wraps as [Value])

Applied to both the template and concrete example sections.

// Before
import { CheckboxListField, type SelectFieldProps } from "@comet/admin";
export type StatusFormState = GQLStatus;
type StatusCheckboxListFieldProps = Omit<SelectFieldProps<StatusFormState>, "options">;

// After
import { CheckboxListField, type CheckboxListFieldProps } from "@comet/admin";
export type StatusFormState = GQLStatus[];
type StatusCheckboxListFieldProps = Omit<CheckboxListFieldProps<GQLStatus>, "options">;

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

…ps and array form state

Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
Copilot AI changed the title [WIP] [WIP] Address feedback from PR #5323 on comet-crud Agent skills Fix CheckboxListField skill template: use CheckboxListFieldProps and array form state Mar 16, 2026
Copilot AI requested a review from manuelblum March 16, 2026 15:43
@manuelblum
manuelblum marked this pull request as ready for review March 16, 2026 19:47
@manuelblum
manuelblum merged commit d17078b into com-2900/add-crud-skills Mar 16, 2026
2 checks passed
@manuelblum
manuelblum deleted the copilot/sub-pr-5323 branch March 16, 2026 19:55
manuelblum added a commit that referenced this pull request Mar 24, 2026
…array form state (#5324)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
vps-manuel-blum pushed a commit that referenced this pull request Jul 20, 2026
…array form state (#5324)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: manuelblum <6098356+manuelblum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants