Merge main into next#1592
Open
vivid-planet-bot wants to merge 6 commits into
Open
Conversation
Merge next into main (v9)
## Summary
`create-app`'s placeholder replacement used a blanket `/[Ss]tarter/g`
regex over **every** scaffolded file, including `package-lock.json`.
This corrupted third-party package names containing `starter`, breaking
API startup for new apps. This PR excludes lock files and `node_modules`
from the replacement.
## What happened in this case
Running `npx @comet/create-app@latest test-comet-app-v9`:
1. `replacePlaceholder` rewrote `@tiptap/starter-kit` →
`@tiptap/test-comet-app-v9-kit` inside `api/` and `admin/` lock files.
2. `install.sh` (`npm install`) honored the corrupted lock, so the real
`@tiptap/starter-kit` was never installed.
3. On startup, `api-generator` loads `@comet/cms-api`, which does
`require("@tiptap/starter-kit")` — and crashed:
```
Error: Cannot find module '@tiptap/starter-kit'
.../@comet/cms-api/lib/blocks/tipTap/createTipTapRichTextBlock.js
```
`@tiptap/starter-kit` is only a transitive dep (via `@comet/cms-api`),
so corrupting the lock entry was enough to make it vanish.
## Fix
In `replacePlaceholder.ts`, changed the glob `ignore` to an array adding
`**/package-lock.json` and `**/node_modules/**`. Lock files are
regenerated by `npm install`, so project-name references reconcile
automatically while third-party names stay intact. `package.json` is
still renamed as before.
Verified: `package.json` name still renamed correctly,
`@tiptap/starter-kit` preserved, install resolves the module; `tsc` and
Prettier pass.
https://claude.ai/code/session_01JShQZ87HSzbaAPAdkR6her
Co-authored-by: Claude <noreply@anthropic.com>
Ports vivid-planet/comet#5994 to comet-starter. ## What Removes the `system-user` filter from `AccessLogModule.forRoot()`'s `shouldLogRequest` in `api/src/app.module.ts`: ```diff -shouldLogRequest: ({ user, req }) => user !== SYSTEM_USER_NAME && !req.route.path.startsWith("/api/healthcheck/"), +shouldLogRequest: ({ req }) => !req.route.path.startsWith("/api/healthcheck/"), ``` ## Why The system-user filter was originally added to reduce logging noise caused by requests made during site builds. Since the site switched to server-side rendering (SSR), those requests are no longer made by the system user, so the filter is obsolete. Healthcheck requests (`/api/healthcheck/`) continue to be excluded from access logs, and the module continues to be registered only when not in debug mode — both unchanged by this PR. `SYSTEM_USER_NAME` is still imported and used elsewhere in `app.module.ts` (for `systemUsers`), so the import is retained. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
vivid-planet/comet#5567 for starter Use the `JsonLd` component from `@comet/site-nextjs` for SEO structured data on `Page` instead of a raw `<script type="application/ld+json">` tag. --- _Generated by [Claude Code](https://claude.ai/code/session_01Vp238wokCaLuYLadMwSaPX)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to merge changes from
mainintonext.