Skip AGENTS.md in replacePlaceholder to preserve comet-starter URLs#1362
Draft
dkarnutsch with Copilot wants to merge 2 commits into
Draft
Skip AGENTS.md in replacePlaceholder to preserve comet-starter URLs#1362dkarnutsch with Copilot wants to merge 2 commits into
dkarnutsch with Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/vivid-planet/comet-starter/sessions/b07b45d5-f939-4e63-9573-4cd293d2d7dd Co-authored-by: dkarnutsch <10632685+dkarnutsch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid links in Agents.md references section
Skip AGENTS.md in replacePlaceholder to preserve comet-starter URLs
Mar 29, 2026
Contributor
|
@thomasdax98 @johnnyomair I'm not really happy with the solution. What do you think? |
johnnyomair
reviewed
Mar 30, 2026
johnnyomair
left a comment
Contributor
There was a problem hiding this comment.
@thomasdax98 @johnnyomair I'm not really happy with the solution. What do you think?
Why? Because of generally excluding AGENTS.md? If yes, an alternative would be to change the placeholder regex to not replace starter if it's part of https://github.com/vivid-planet/comet-starter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
npx @comet/create-appscaffolds a new project, it replaces all occurrences ofstarter/Starterwith the project name.AGENTS.mdcontains hardcoded GitHub URLs referencingcomet-starterin its References section — these are correctly pointing at the template repo and must not be replaced.Change
create-app/src/util/replacePlaceholder.ts: Add an early-return guard forAGENTS.md, skipping it entirely from placeholder substitution — consistent with the existing special-case handling forintl-update.sh.Without this, URLs like
https://api.github.com/repos/vivid-planet/comet-starter/contents/{path}would be rewritten to use the project name, breaking all starter repo references in AI agent guidance.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
iojs.org/usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o -(dns block)If you need me to access, download, or install something from one of these locations, you can either:
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.