Conversation
Fixes WebView2 flickering when resizing the toolbox window. Signed-off-by: effects3d <effects3dee@gmail.com>
Signed-off-by: effects3d <effects3dee@gmail.com>
- bootstrapper.go: a Roblox log line with exactly two commas hit panic(entry) in handleRobloxLog due to an off-by-one in the SplitN guard (3 elements passed the < 3 check, then entry[3:] was empty). Require the full 4-element split instead. - bootstrapper_roblosec.go: getSecurity read Wine credential-registry values via GetValue(...).Data.([]byte) with no nil check or comma-ok assertion, panicking on a missing or malformed credential store instead of returning the error the caller already handles. Factored into a small registryBytes helper used at all three call sites. - manager_bind.go: addKeyRow panicked on any FFlags value whose TOML type isn't bool/string/int64 (e.g. a float or an array), crashing the Settings window on open for an otherwise valid config.toml. Fall back to an editable text row instead. Verified: go build ./..., go vet, gofmt, and go test ./... all pass.
Member
|
LLM contributions are not accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three spots parse external/config input and
panic()on an unexpected shape instead of degrading. Found while reading through the codebase; each is small and independently verifiable.1.
bootstrapper.go— log line with exactly two commas crashes the GUIhandleRobloxLogdoesstrings.SplitN(line, ",", 4). A line with exactly two commas returns 3 elements, which clears thelen(entry) < 3guard;entry[3:]is then empty, solen(entry) != 1is true and it hitspanic(entry). Requiring the full 4-element split fixes it and matches the documented format (time,runtime,code,code2[,level] ...).2.
bootstrapper_roblosec.go— nil-deref / type-assert panics on the Wine credential registrygetSecurityread three registry values viaGetValue(...).Data.([]byte)with no nil check and no comma-ok assertion. A missing or malformedHKCU\Software\Wine\Credential Managerkey panics instead of returning the errorsetupExecutealready handles ("Retrieving authenticated user failed"). Factored the three call sites into a smallregistryByteshelper that returns an error instead.3.
manager_bind.go— Settings window crashes on an fflag with an unexpected TOML typeFFlagsismap[string]any; TOML decodes a fractional number tofloat64and arrays/tables to other types, none of which theaddKeyRowswitch handles, so it panics. Aconfig.tomlwith e.g.DFIntFoo = 1.5under[studio.fflags]crashes the Settings window the moment it's opened, even though the config is otherwise valid TOML. Falls back to an editable text row instead of panicking.Verified
go build ./...,go vet ./...,gofmt, andgo test ./...all pass with these changes; no new vet findings introduced (the existing unkeyed-field/unsafe.Pointer warnings elsewhere are pre-existing and untouched).